Add SwiftUI and some compose refactors #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching upstream
[Description] Preparing for introducing Compose, which requires Android Studio Canary, which requires Gradle 7+ [Solution] - Upgrade Gradle and Android Gradle Plugin - Make necessary changes to accomodate the new Gradle and AGP APIs [Testing] - ./gradlew build - manual testing of Android and iOS apps
[Description] Jetpack Compose is going stable in July 2021, and we want to show folks the easiest way to get started with KMM using Compose. [Solution] - Add Compose UI, and support SwipeRefresh using Accompanist. - Remove XML layouts. [Testing] - ./gradlew :shared:build :app:build - manual testing
[Summary] The Loading UI is usually shown in conjunction with other UI, such as an error view, or valid data. Consuming it with a when statement and treating it like any other state may not make sense with Compose and Swift UI. I tried a different approach here, giving the Loading state the last valid DataState as well: #6 [Fix] In this PR, I'm using the classic NetworkBoundResource approach, where the DataState is not a sealed class; instead, it contains nullable versions of all possible states. [Testing] - `./gradlew :app:build` - `./gradlew :shared:build` - `xcodebuild -workspace ios/KaMPKitiOS.xcworkspace -scheme KaMPKitiOS -sdk iphoneos -configuration Debug build -destination name="iPhone 8"` - manual testing
| import org.koin.androidx.viewmodel.ext.android.viewModel | ||
| import org.koin.core.component.KoinComponent | ||
| import org.koin.core.component.inject | ||
| import org.koin.core.parameter.parametersOf | ||
|
|
||
| class MainActivity : AppCompatActivity(), KoinComponent { | ||
| class MainActivity : ComponentActivity(), KoinComponent { |
There was a problem hiding this comment.
AppCompatActivity is a ComponentActivity; why the change?
brady-aiello
approved these changes
Jul 28, 2021
kpgalligan
approved these changes
Aug 5, 2021
mrf7
approved these changes
Aug 5, 2021
| color = MaterialTheme.colors.background, | ||
| modifier = Modifier.fillMaxSize() | ||
| ) { | ||
| val isRefreshingState by remember(dogsState) { |
There was a problem hiding this comment.
I'm pretty sure this can be changed to just isRefreshing = dogsState.loading since its not doing any calculation, or just removed and do rememberSwipeRefreshState(isRefreshing = dogsState.loading) below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/touchlab/KaMPKit/issues/[issue number]
[Platform]
[Summary]
[Fix]
[Testing]
Reviewer Tips:
* Use "Nitpick:" if it's a minor non-crucial request.
* If you're done with comments either end with a review or comment something helpful like "done with comments for now"