New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftUI and some compose refactors #201
Merged
Merged
Commits on Mar 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 02dd01b - Browse repository at this point
Copy the full SHA 02dd01bView commit details
Commits on Jun 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 65ba498 - Browse repository at this point
Copy the full SHA 65ba498View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57768d3 - Browse repository at this point
Copy the full SHA 57768d3View commit details
Commits on Jun 29, 2021
-
[Issue-0000] Upgrade to Gradle 7
[Description] Preparing for introducing Compose, which requires Android Studio Canary, which requires Gradle 7+ [Solution] - Upgrade Gradle and Android Gradle Plugin - Make necessary changes to accomodate the new Gradle and AGP APIs [Testing] - ./gradlew build - manual testing of Android and iOS apps
Configuration menu - View commit details
-
Copy full SHA for 781a293 - Browse repository at this point
Copy the full SHA 781a293View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6084a1 - Browse repository at this point
Copy the full SHA d6084a1View commit details
Commits on Jul 8, 2021
-
[Issue-0000] Add Jetpack Compose
[Description] Jetpack Compose is going stable in July 2021, and we want to show folks the easiest way to get started with KMM using Compose. [Solution] - Add Compose UI, and support SwipeRefresh using Accompanist. - Remove XML layouts. [Testing] - ./gradlew :shared:build :app:build - manual testing
Configuration menu - View commit details
-
Copy full SHA for cc19c52 - Browse repository at this point
Copy the full SHA cc19c52View commit details -
Configuration menu - View commit details
-
Copy full SHA for dabf620 - Browse repository at this point
Copy the full SHA dabf620View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f77a19 - Browse repository at this point
Copy the full SHA 5f77a19View commit details
Commits on Jul 19, 2021
-
[Issue-0000] Alternative Loading state refactor
[Summary] The Loading UI is usually shown in conjunction with other UI, such as an error view, or valid data. Consuming it with a when statement and treating it like any other state may not make sense with Compose and Swift UI. I tried a different approach here, giving the Loading state the last valid DataState as well: #6 [Fix] In this PR, I'm using the classic NetworkBoundResource approach, where the DataState is not a sealed class; instead, it contains nullable versions of all possible states. [Testing] - `./gradlew :app:build` - `./gradlew :shared:build` - `xcodebuild -workspace ios/KaMPKitiOS.xcworkspace -scheme KaMPKitiOS -sdk iphoneos -configuration Debug build -destination name="iPhone 8"` - manual testing
Configuration menu - View commit details
-
Copy full SHA for 7c1dfaa - Browse repository at this point
Copy the full SHA 7c1dfaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4adcf7 - Browse repository at this point
Copy the full SHA e4adcf7View commit details
Commits on Jul 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2685a43 - Browse repository at this point
Copy the full SHA 2685a43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 462e650 - Browse repository at this point
Copy the full SHA 462e650View commit details -
Configuration menu - View commit details
-
Copy full SHA for a047aef - Browse repository at this point
Copy the full SHA a047aefView commit details -
Configuration menu - View commit details
-
Copy full SHA for b15e3a4 - Browse repository at this point
Copy the full SHA b15e3a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c7d485 - Browse repository at this point
Copy the full SHA 0c7d485View commit details
Commits on Jul 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 51ce5ec - Browse repository at this point
Copy the full SHA 51ce5ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb1873 - Browse repository at this point
Copy the full SHA 8eb1873View commit details -
Configuration menu - View commit details
-
Copy full SHA for 935848a - Browse repository at this point
Copy the full SHA 935848aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6c399e - Browse repository at this point
Copy the full SHA c6c399eView commit details
Commits on Aug 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8a2ba93 - Browse repository at this point
Copy the full SHA 8a2ba93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66b102d - Browse repository at this point
Copy the full SHA 66b102dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6db990c - Browse repository at this point
Copy the full SHA 6db990cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.