Add an explicit error that SKIE does not support bitcode embedding.

touchlab · Mar 6, 2024 · 4cc10ac · 4cc10ac
1 parent 1100126
commit 4cc10ac
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/...ompiler/kotlin-plugin/src/kgp_common/kotlin/co/touchlab/skie/phases/SkiePhaseScheduler.kt b/...ompiler/kotlin-plugin/src/kgp_common/kotlin/co/touchlab/skie/phases/SkiePhaseScheduler.kt
@@ -46,6 +46,7 @@ import co.touchlab.skie.phases.other.ExtraClassExportPhase
 import co.touchlab.skie.phases.other.FixDuplicatedOverridenFunctionsPhase
 import co.touchlab.skie.phases.other.FixLibrariesShortNamePhase
 import co.touchlab.skie.phases.other.VerifyMinOSVersionPhase
+import co.touchlab.skie.phases.other.VerifyNoBitcodeEmbeddingPhase
 import co.touchlab.skie.phases.runtime.ConfigureStableNameTypeAliasesForKotlinRuntimePhase
 import co.touchlab.skie.phases.runtime.KotlinRuntimeHidingPhase
 import co.touchlab.skie.phases.runtime.SwiftRuntimeGenerator
@@ -78,6 +79,7 @@ class SkiePhaseScheduler {
             ClassExportAnalyticsPhase,
             ExtraClassExportPhase(context),
             VerifyMinOSVersionPhase,
+            VerifyNoBitcodeEmbeddingPhase,
         )
     }
 

diff --git a/...ugin/src/kgp_common/kotlin/co/touchlab/skie/phases/other/VerifyNoBitcodeEmbeddingPhase.kt b/...ugin/src/kgp_common/kotlin/co/touchlab/skie/phases/other/VerifyNoBitcodeEmbeddingPhase.kt
@@ -0,0 +1,20 @@
+package co.touchlab.skie.phases.other
+
+import co.touchlab.skie.phases.ClassExportPhase
+import org.jetbrains.kotlin.backend.konan.BitcodeEmbedding
+import org.jetbrains.kotlin.backend.konan.KonanConfigKeys
+
+object VerifyNoBitcodeEmbeddingPhase : ClassExportPhase {
+
+    context(ClassExportPhase.Context)
+    override fun execute() {
+        val bitcodeEmbeddingMode = compilerConfiguration[KonanConfigKeys.BITCODE_EMBEDDING_MODE]
+
+        if (bitcodeEmbeddingMode == BitcodeEmbedding.Mode.FULL) {
+            error(
+                "Bitcode embedding is not supported by SKIE. " +
+                    "To disable bitcode embedding you likely need to remove `embedBitcode(BitcodeEmbeddingMode.BITCODE)` from the Gradle build script.",
+            )
+        }
+    }
+}