Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypy version closes editor on run #46

Closed
deep-gaurav opened this issue Jan 12, 2018 · 11 comments
Closed

pypy version closes editor on run #46

deep-gaurav opened this issue Jan 12, 2018 · 11 comments

Comments

@deep-gaurav
Copy link

deep-gaurav commented Jan 12, 2018

When a scene is played with pypy as GDNative Library it closes the editor although the scene runs and works correctly,

It does not happen when CPython is used.

Tested on Linux amd64, with both Godot master and Godot beta.

@touilleMan
Copy link
Owner

Tested on Linux arm64

ARM64 ??? really ? That's pretty impressive ;-)

For your trouble, do you have a logs output ?

@deep-gaurav
Copy link
Author

deep-gaurav commented Jan 12, 2018

Lol sorry, that's amd 64, I'll upload logs

But that arm 64 reminds me, do you think it's possible to make Godot python work by replacing bin directory of godot-python by python-for-androids python built? It seems to have same files (names at least)

@touilleMan
Copy link
Owner

I would say linux arm 64 would be pretty straightforward (just need to setup a cross compiler and use/build CPython for the platform), but I have no experience with this architecture so I might be missing something there...

@deep-gaurav
Copy link
Author

deep-gaurav commented Jan 13, 2018

output

more specific error, Editor crashes on defocusing it, and I suppose so, on run it changes focus to played scene thus the editor disappears.

I am not sure how to get logs output,

Here is what I get by using -d and -v flag of godot

image

nothing regarding crash

@touilleMan
Copy link
Owner

Strange... in the log the PYTHONPATH: [...] is outputed from Python, which means the dll has been successfully loaded and are running fine.

I see you use the label node, however the GDnative string API has change recently, so it maybe something like that (should explain the bug in the master branch, but not in the beta2 which doesn't contain this...)

Have you tried to put a import pdb; pdb.set_trace() in your python file ? typically at the top of the file (should be hit when the module is loaded) and in your method.

@deep-gaurav
Copy link
Author

Well it only occurs in pypy version in both beta 2 and master branch of 11th Jan,.
script does is working fine as label text and scale changed.

Strangely on adding import pdb;pdb.set_trace() the script stopped working and text didnt changed nor did label and editor did crashed like before

image
Error that I received, just one line from scrip outputted

@touilleMan
Copy link
Owner

I've fixed some memory leaks that could have been the cause of this (but it is related to godotengine/godot#15761 which is not yet merged...)

@deep-gaurav
Copy link
Author

I cannot reproduce this issue on any other project with latest godot-python and Godot. Although it still exist in that project. I could've misconfigured something.

@touilleMan
Copy link
Owner

touilleMan commented Jan 31, 2018 via email

@deep-gaurav
Copy link
Author

Never mind, it's solved, I was cleaning old .gdnlib and .gdns files to mail you and deleting them solved problem, seems I misconfugured pythonscript.gdnlib file(it wasnt provided earlier),

@touilleMan
Copy link
Owner

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants