Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Batch #2 #5

Closed
wants to merge 17 commits into from
Closed

WIP: Batch #2 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5dcbf1b
Compiling successful after refactor, tests broken
zph Mar 14, 2021
d5800f0
Auto-formatting and argument changes
zph Mar 15, 2021
5859173
Revert to using existing pattern for init
zph Mar 15, 2021
df9ce5f
Print errors to stderr
zph Mar 16, 2021
fa72ab6
Successfully generate basic commandline completions from clap_generat…
zph Mar 16, 2021
c882075
Update tests to match completion expectations
zph Mar 16, 2021
572e3a0
Autoformatting
zph Mar 16, 2021
9ba52b6
Allow for non octothorp driven languages for help and source directives
zph Mar 16, 2021
0d51fe9
Allow for // type help lines
zph Mar 16, 2021
43a1b70
Add about definitions for all subcommands
zph Mar 17, 2021
6d6b4fc
Fix incorrect dependency source for clap_generate
zph Mar 17, 2021
b0360f6
Add helper scripts for testing and linting
zph Mar 19, 2021
8b79b32
Update fish completion in init_v2
zph Mar 26, 2021
2c593be
Merge branch 'master' into use-clap
zph Apr 5, 2021
e520d97
Merge branch 'toumorokoshi:master' into use-clap
zph Jun 2, 2021
61098dc
Convert -h to help subcommand per design spec
zph Jun 6, 2021
b87073a
Extract duplicate definitions in clap init
zph Jun 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
322 changes: 270 additions & 52 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ edition = "2018"
license = "MIT"

[dependencies]
tui = "0.3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because they didn't look used.

termion = "*"


clap = "3.0.0-beta.2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chose beta because of most up to date auto-generated shell completions.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, ultimately we produce a compiled binary so the use of beta internally is less of an issue I think.

clap_generate = "3.0.0-beta.2"
log = "*"
env_logger = "*"

[dev-dependencies]
Loading