Skip to content

Commit

Permalink
version dictionary is now case-insensitive.
Browse files Browse the repository at this point in the history
  • Loading branch information
toumorokoshi committed Dec 20, 2016
1 parent e1b322d commit 8c09037
Show file tree
Hide file tree
Showing 3 changed files with 62 additions and 1 deletion.
35 changes: 35 additions & 0 deletions tests/packages/test_versions.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import pytest
from uranium.packages.versions import Versions


@pytest.fixture
def versions():
return Versions()


def test_versions_coerce_lowercase(versions):
"""
coerce package names to lowercase
"""
versions["SQLAlchemy"] = "==1.0.11"
assert versions["sqlalchemy"] == "==1.0.11"


def test_versions_coerce_lowercase_update(versions):
"""
coerce package names to lowercase for update.
"""
versions.update({
"SQLAlchemy": "==1.0.11"
})
assert versions["sqlalchemy"] == "==1.0.11"


def test_versions_coerce_lowercase_get(versions):
"""
getting a package name should also be lowercase.
"""
versions.update({
"SQLAlchemy": "==1.0.11"
})
assert versions["SQLAlchemy"] == "==1.0.11"
3 changes: 2 additions & 1 deletion uranium/packages/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from ..lib.asserts import get_assert_function
from ..exceptions import PackageException
from .install_command import install
from .versions import Versions

p_assert = get_assert_function(PackageException)

Expand All @@ -16,7 +17,7 @@ class Packages(object):
"""

def __init__(self):
self._versions = {}
self._versions = Versions()
self._index_urls = list(DEFAULT_INDEX_URLS)

@property
Expand Down
25 changes: 25 additions & 0 deletions uranium/packages/versions.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
from collections import MutableMapping


class Versions(MutableMapping):
""" a dictionary containing version specs. """

def __init__(self):
self._values = {}

def __setitem__(self, key, value):
key = str(key).lower()
self._values[key] = value

def __getitem__(self, key):
key = str(key).lower()
return self._values[key]

def __delitem__(self, key):
del self._values[key]

def __iter__(self):
return iter(self._values)

def __len__(self):
return len(self._values)

0 comments on commit 8c09037

Please sign in to comment.