fix updating already deleted booking (calcom#5201)

Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com>
tourlane · Nov 22, 2022 · bbffa44 · bbffa44
1 parent eaaae24
commit bbffa44
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/packages/app-store/zapier/lib/nodeScheduler.ts b/packages/app-store/zapier/lib/nodeScheduler.ts
@@ -49,7 +49,8 @@ export async function scheduleTrigger(
 
 export async function cancelScheduledJobs(
   booking: { uid: string; scheduledJobs?: string[] },
-  appId?: string | null
+  appId?: string | null,
+  isReschedule?: boolean
 ) {
   let scheduledJobs = booking.scheduledJobs || [];
 
@@ -70,14 +71,16 @@ export async function cancelScheduledJobs(
         scheduledJobs = [];
       }
 
-      await prisma.booking.update({
-        where: {
-          uid: booking.uid,
-        },
-        data: {
-          scheduledJobs: scheduledJobs,
-        },
-      });
+      if (!isReschedule) {
+        await prisma.booking.update({
+          where: {
+            uid: booking.uid,
+          },
+          data: {
+            scheduledJobs: scheduledJobs,
+          },
+        });
+      }
     });
   }
 }
diff --git a/packages/features/bookings/lib/handleNewBooking.ts b/packages/features/bookings/lib/handleNewBooking.ts
@@ -890,7 +890,7 @@ async function handler(req: NextApiRequest & { userId?: number | undefined }) {
 
     subscribersMeetingEnded.forEach((subscriber) => {
       if (rescheduleUid && originalRescheduledBooking) {
-        cancelScheduledJobs(originalRescheduledBooking);
+        cancelScheduledJobs(originalRescheduledBooking, undefined, true);
       }
       if (booking && booking.status === BookingStatus.ACCEPTED) {
         scheduleTrigger(booking, subscriber.subscriberUrl, subscriber);