Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] feat: Add options to share on social media from video cards/analysis page #1606

Closed
lfaucon opened this issue Jun 8, 2023 · 7 comments
Assignees
Labels
Frontend Front-end code of Tournesol UX
Projects

Comments

@lfaucon
Copy link
Member

lfaucon commented Jun 8, 2023

No description provided.

@lfaucon lfaucon created this issue from a note in kanban (Ready) Jun 8, 2023
@ShinseiNova
Copy link
Collaborator

ShinseiNova commented Jun 8, 2023

Current design :

The compare button is at the top since it's supposed to be the priority
Capture du 2023-06-08 17-09-03

New design :

With the new share buttons and the toolbar under the video to stay close to the youtube and extension design (so it's more intuitive)
Capture du 2023-06-08 17-25-59

Maybe taking out of the videocard the rate-later button as well would be better ?

What are your thoughts ?

@amatissart
Copy link
Member

@ShinseiNova It looks good to me 👍
As the "Compare" button is no longer present in the video card, I think it would make sense to remove all actions buttons from the video card on this page, and move the "Rate Later" action on the line of blue buttons.

@lfaucon
Copy link
Member Author

lfaucon commented Jun 8, 2023

Looks good!

Some thoughts:
(A) are there easy integrations with other social media than Twitter?
(B) can we have both a "copy link" and a "copy social media message"?
(C) I think I would prefer keeping the action buttons on the card, even if they would be duplicated. I think this helps users learn about them and use them well

@GresilleSiffle GresilleSiffle added Frontend Front-end code of Tournesol UX labels Jun 12, 2023
@GresilleSiffle GresilleSiffle moved this from Ready to In progress in kanban Jun 12, 2023
@GresilleSiffle GresilleSiffle added this to the Analysis page overhaul milestone Jun 12, 2023
@GresilleSiffle GresilleSiffle moved this from In progress to Under review in kanban Jul 5, 2023
@ShinseiNova
Copy link
Collaborator

We could try to implement other social media. (e.g. linkedin)
If we stick to standard ones with a wide enough use they might not be adapted. (e.g. facebook, instagram, not to mention tiktok).
If we try with some more niche media, maybe only one or so users might use the feature, is it worth it ?

@lfaucon
Copy link
Member Author

lfaucon commented Jul 9, 2023

My opinion:

  • LinkedIn: Yes.
  • Facebook: Yes.
  • Instagram: Maybe. I guess that sharing on Instagram requires an image? Is it feasible to re-use the video preview image for this?
  • Tiktok: No. Because of the negative aspects of Tiktok.

Only doing the integration if the corresponding social network has a simple API for it.

I think the team would agree, please raise this as a discussion point in one of our next weekly.

@GresilleSiffle
Copy link
Collaborator

Facebook and LinkedIn would be nice. I have the same feeling about Instagram and TikTok.

@lfaucon
Copy link
Member Author

lfaucon commented Oct 5, 2023

Closing, future work on this will be done on #1800 and #1801

@lfaucon lfaucon closed this as completed Oct 5, 2023
@lfaucon lfaucon moved this from Under review to Done in kanban Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Front-end code of Tournesol UX
Projects
Development

No branches or pull requests

4 participants