Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] feat: Add options to share on social media from video cards/analysis page #1668

Merged
merged 17 commits into from
Jul 11, 2023

Conversation

ShinseiNova
Copy link
Collaborator

@ShinseiNova ShinseiNova commented Jul 5, 2023

related to #1606
image
image

@ShinseiNova ShinseiNova self-assigned this Jul 5, 2023
@ShinseiNova ShinseiNova marked this pull request as ready for review July 5, 2023 12:15
@ShinseiNova ShinseiNova added the Frontend Front-end code of Tournesol label Jul 5, 2023
@GresilleSiffle
Copy link
Collaborator

I like the new design, and I like to have the compare and add to rate-later buttons here instead of in the metadata box.

  • the buttons are bigger, easier to see, harder to miss
  • their position reminds me of the YouTube layout
  • they feel more engaging to me

I'd be OK to create a new UX rule in the front end:

  • when a video is displayed with VideoCard containing a thumbnail, the actions are displayed in the metadata box
  • when a video is meant to be watched (only one player on the screen, wide format), the actions are displayed under the player to match the YouTube layout

@GresilleSiffle
Copy link
Collaborator

GresilleSiffle commented Jul 6, 2023

Review:

  • convert the CopyContent icon to a share icon (deploying the old menu allowing the users to copy the page address)
  • add a new entry to this menu to copy the "share message"

@lfaucon
Copy link
Member

lfaucon commented Jul 6, 2023

To support both copying the address and copying a message to be share on Social Networks
Screenshot 2023-07-06 at 12 24 34

@ShinseiNova
Copy link
Collaborator Author

Do we want something like that ? Or should we keep a separate button for Twitter
image

@ShinseiNova ShinseiNova marked this pull request as draft July 6, 2023 15:14
@lfaucon
Copy link
Member

lfaucon commented Jul 9, 2023

Do we want something like that ? Or should we keep a separate button for Twitter

Unsure.
I like the suggestion.
Seeing the blue Share on Twitter button that you propose in the first design may be helpful for the sharing feature to be easily discovered.

Pick the option you like best 👍

@ShinseiNova
Copy link
Collaborator Author

ShinseiNova commented Jul 10, 2023

Do we want something like that ? Or should we keep a separate button for Twitter

Unsure. I like the suggestion. Seeing the blue Share on Twitter button that you propose in the first design may be helpful for the sharing feature to be easily discovered.

Pick the option you like best +1

Thank you

I prefer keeping it separated as you said, since Twitter is the place people share the most for now.
Maybe to then add other social media and make a second more generic "share on social media button" in the future.

@ShinseiNova ShinseiNova marked this pull request as ready for review July 10, 2023 09:17
@GresilleSiffle GresilleSiffle merged commit 19c5d8e into main Jul 11, 2023
@GresilleSiffle GresilleSiffle deleted the front-share_videos_socialmedia branch July 11, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Front-end code of Tournesol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants