Fixed used after free bug in ffi_type_array_create #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libffi-rs/src/middle/types.rs
Outdated
| @@ -102,6 +102,7 @@ where | |||
| let new = ffi_type_array_create_empty(size); | |||
| for (i, element) in elements.enumerate() { | |||
| *new.add(i) = *element.0; | |||
| forget(element); | |||
There was a problem hiding this comment.
@xtldr forget itself isn't imported, instead std::mem as a whole is imported. This means you have to use mem::forget(element) here.
There was a problem hiding this comment.
@yorickpeterse Yes of course. I shouldn't use the online editor to create patches without testing, even for one liners. I have fixed it now.
|
@xtldr Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
middle::types::ffi_type_array_createtheffi_typeofelementis copied tonew, but whenelementis dropped at the end of the loop, theffi_typeis deallocated while still readable fromnew.If we add
forget(element), theffi_typewon't be deallocated. SinceType::droponly deallocates it'sffi_type, this should be safe because theffi_typeis now owned by the resultingTypeArray.