Fix crash on missing wakeword #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When something goes wrong during initialization of the audio recorder, we want to inform the user.
This allows us to use ESP-IDF's ESP_RETURN_ON_ERROR macro inside the function, so we can skip printing the wake help text in case something goes wrong.
If the SR recorder cannot be created for some reason, we currently just print "Ready!" on the display. Improve UX by informing the user about the problem.
stintel
force-pushed
the
fix/crash_missing_wakeword
branch
from
6b7857e
to
a7a146d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.