Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic if * is used with AllowOrigin::list #285

merged 3 commits into from
Jul 15, 2022


Copy link

@davidpdrsn davidpdrsn requested a review from jplatte July 15, 2022 11:36
@davidpdrsn davidpdrsn mentioned this pull request Jul 15, 2022
Copy link

jplatte commented Jul 15, 2022

I wonder whether we should instead panic. I don't see why you would legitimately provide both a wildcard which allows any origin, and other values.

Copy link
Member Author

Yeah that's fine with me as well.

Copy link
Member Author

@jplatte I've changed it to panic.

@davidpdrsn davidpdrsn changed the title Handle * in AllowOrigin::list Panic if * is used with AllowOrigin::list Jul 15, 2022
@davidpdrsn davidpdrsn merged commit 913683b into master Jul 15, 2022
@davidpdrsn davidpdrsn deleted the cors-handle-wildcard-in-allow-origin-lists branch July 15, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

2 participants