Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do compress grpc-web responses #408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bouk
Copy link

@bouk bouk commented Sep 11, 2023

Related: #215

Motivation

grpc-web responses aren't compressed right now, but they should be.

Solution

Add exception for application/grpc-web and change exception filter to use starts_with so we match on any encoding format.

@bouk
Copy link
Author

bouk commented Mar 25, 2024

@jplatte can you take a look at this one?

@jplatte
Copy link
Collaborator

jplatte commented Apr 7, 2024

Is there a piece of documentation or article that you can link to for justification / proof that this is the right thing to do? I'm not really familiar with GRPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants