Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deny Action failures in CI #468

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix Deny Action failures in CI #468

merged 1 commit into from
Feb 14, 2024

Conversation

privettoli
Copy link
Contributor

Motivation

Fixes deny action CI failures like in PR #467.

Solution

  • Specify manifest-path as a separate input property instead of in arguments
  • Removes arguments because the new value is the default

@privettoli
Move manifest-path to inputs
4b70cf8 
- Fixes deny action CI failures like in PR#467.
- Removes `arguments` because the new value [is the default](https://github.com/EmbarkStudios/cargo-deny-action/blob/68cd9c5e3e16328a430a37c743167572e3243e7e/action.yml#L17)
@privettoli privettoli changed the title Move manifest-path to inputs Fix Deny Action failures in CI Feb 14, 2024
jplatte
jplatte approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jplatte jplatte merged commit 601ba88 into tower-rs:main Feb 14, 2024
11 checks passed
@privettoli privettoli deleted the privettoli/467-fix-ci-failures branch February 14, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@privettoli @jplatte