Why is Http<OtherExecutor> not supported

[hicqu]

I'm confused why Http<DefaultExecutor> is the only choise in Server::serve_with. Is there any special reasons to forbid Http<tokio_threadpool::Sender>?

[LucioFranco]

hi @hicqu!

Yeah, this is a limitation due to the fact that hyper does not expose its H2Exec trait and Exec enum. Here is the related issue. I am going to revert the change that added the Serve future to just use a Box<Future> for now since this will allow us to erase and punt on the bounds for the executor. This should enable you to use any executor.

Let me know if there is any issue with this.

[LucioFranco]

PR is up at #28

[hicqu]

Thank you. It can be closed now.

[hicqu]

Hi, sorry for closing this issue without try your fix. After tried it I found that hyper::common::server::Exec is private, so I can't call http.with_executor(Exec::executor(...)) to use a tokio pool as the executor. However I can call a deprecated function http.executor(any_my_executor) to associate my executor to the server. Could you show me the best solution?

[LucioFranco]

@hicqu this is a good question...I'm not totally sure but this seems more appropriate to make an issue in the hyper repo?

That said, you might be able to satisfy this bound to get it to work? https://github.com/hyperium/hyper/blob/master/src/common/exec.rs#L116

[LucioFranco]

@hicqu can this be closed or are you still seeing issues?

[hicqu]

It can be closed. Thank you!