Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect::new() Generic parameters are redundant #737

Closed
artshell opened this issue May 28, 2023 · 2 comments · Fixed by #755
Closed

Reconnect::new() Generic parameters are redundant #737

artshell opened this issue May 28, 2023 · 2 comments · Fixed by #755

Comments

@artshell
Copy link

Reconnect::new() Generic parameters are redundant

S, Request>

    pub fn new<S, Request>(mk_service: M, target: Target) -> Self {
        Reconnect {
            mk_service,
            state: State::Idle,
            target,
            error: None,
        }
    }
@GlenDC GlenDC mentioned this issue Dec 5, 2023
Merged
@GlenDC
Copy link
Contributor

GlenDC commented Dec 5, 2023

Good spot, opened a PR for you at #755

@artshell
Copy link
Author

artshell commented Dec 5, 2023

@GlenDC

thanks!

@tobz tobz closed this as completed in #755 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove generic parameters from Reconnect::new GlenDC/tower
2 participants
@GlenDC @artshell