ready-cache: Properly expose error source #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ready_cache::error::Failed` type does not actually expose its inner error type via `Error::source`. This change fixes this and improves debug formatting.
olix0r
force-pushed
the
ver/ready-cache-error-fixup
branch
from
c9ce694
to
b6ff55b
Compare
jonhoo
reviewed
Aug 30, 2020
| @@ -6,9 +6,12 @@ pub struct Failed<K>(pub K, pub crate::BoxError); | |||
|
|
|||
| // === Failed === | |||
|
|
|||
| impl<K> std::fmt::Debug for Failed<K> { | |||
| impl<K: std::fmt::Debug> std::fmt::Debug for Failed<K> { | |||
There was a problem hiding this comment.
Note that this is a backwards-incompatible change. So would have to be slated for next major release (which I guess we're in the process of preparing probably). cc @LucioFranco
There was a problem hiding this comment.
we are, in fact (and linkerd already depends on tower master)
There was a problem hiding this comment.
👍 I am hoping to hop back on after tokio 0.3 so fine to push this onto master
jonhoo
approved these changes
Aug 30, 2020
hawkw
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ready_cache::error::Failedtype does not actually expose its innererror type via
Error::source. This change fixes this and improvesdebug formatting.