hedge: don't reserve slots for hedged requests #472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hedge
wrapsS: Service + Clone
and is essentially implemented asSelect<S, Delay<S>>
, whosecall
implementation creates two responsefutures and selects the one which resolves first. The second response
future is obtained from
Delay<S>::call
, which waits for some timebefore calling
S::call
.The current implementation of
Delay<S>::poll_ready
callsS::poll_ready
unconditionally. However, theS::call
correspondingto that
poll_ready
only happens after much delay, if ever. Thisinteracts badly with
Buffer
, which usespoll_ready
to reserve achannel slot. When using
Hedge
with aBuffer
'd service, the innerBuffer::poll_ready
is called twice, but only one slot is usedimmediately. This causes exhaustion of all of the
Buffer
slots.Instead, return
Poll::Ready(Ok(()))
fromDelay::poll_ready
and use aOneshot
inside of theDelay
future.