Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer: fix+improve doc links #487

Merged
merged 3 commits into from
Dec 28, 2020
Merged

layer: fix+improve doc links #487

merged 3 commits into from
Dec 28, 2020

Conversation

GeorgeHahn
Copy link
Contributor

  • Fixes a link to the Service trait on the tower_layer module page. (current page)
  • Adds a link to Service on the Layer trait page. (current page)

These changes use old style links - intra-rustdoc links won't work here because tower/tower_service aren't referenced by this crate.

hawkw
hawkw approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! If we update from the latest master, we should get a successful CI build and then I'll be happy to merge this.

@hawkw hawkw merged commit 704bfa8 into tower-rs:master Dec 28, 2020
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeorgeHahn @hawkw