Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ServiceBuilder::service take self by reference #504

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Make ServiceBuilder::service take self by reference #504

merged 3 commits into from
Jan 4, 2021

Conversation

davidpdrsn
Copy link
Member

Fixes #501

hawkw
hawkw approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

@davidpdrsn
Copy link
Member Author

Forgot to update changelog 😊

@hawkw hawkw merged commit d0fde83 into tower-rs:master Jan 4, 2021
@davidpdrsn davidpdrsn deleted the service-builder-self-by-ref branch January 4, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider making ServiceBuilder::service take &self
2 participants
@davidpdrsn @hawkw