util: impl Clone for AndThen, MapRequest and MapErr layers
#525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Layer` types for `AndThen`, `MapRequest`, and `MapErr` middleware were missing `Clone` impls, which the `MapResponse`, `MapResult`, and `Then` middleware's layer types *do* have. These layers should all be `Clone` when the function is `Clone`. I've added `derive(Clone)` to all these layer types.
LucioFranco
approved these changes
Jan 12, 2021
olix0r
approved these changes
Jan 12, 2021
yes, although it's a potential compatibility issue if we ever add additional fields that are not trivially |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Layertypes forAndThen,MapRequest, andMapErrmiddlewarewere missing
Cloneimpls, which theMapResponse,MapResult, andThenmiddleware's layer types do have. These layers should all beClonewhen the function isClone.I've added
derive(Clone)to all these layer types.