Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: Add ServiceBuilder::map_result #583

Merged
merged 1 commit into from May 7, 2021
Merged

builder: Add ServiceBuilder::map_result #583

merged 1 commit into from May 7, 2021

Conversation

davidpdrsn
Copy link
Member

Noticed that ServiceBuilder didn't have map_result, only then which is async.

@davidpdrsn
builder: Add ServiceBuilder::map_result
dbb241f 
Noticed that `ServiceBuilder` didn't have `map_result`, only `then`
which is async.
@davidpdrsn davidpdrsn added the A-builder Area: Tower's service builder label Apr 28, 2021
hawkw
hawkw approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, lgtm!

@hawkw hawkw merged commit 53ec99e into master May 7, 2021
@hawkw hawkw deleted the david/builder-map-result branch May 7, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
A-builder Area: Tower's service builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidpdrsn @hawkw