Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Layer for ServiceBuilder #600

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Implement Layer for ServiceBuilder #600

merged 1 commit into from
Sep 3, 2021

Conversation

davidpdrsn
Copy link
Member

@jonhoo from discord:

I may feel silly for asking this, but why doesn't ServiceBuilder implement Layer?
Like, it has into_inner, but why is the indirection required?

I have wondered the same thing. It compiles and seems sensible to me.

jonhoo
jonhoo approved these changes Sep 3, 2021
View reviewed changes
Copy link
Collaborator

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@davidpdrsn davidpdrsn merged commit d91c0f5 into master Sep 3, 2021
@davidpdrsn davidpdrsn deleted the builder-layer branch September 3, 2021 16:54
davidpdrsn added a commit that referenced this pull request Oct 13, 2021
@davidpdrsn
tower: prepare to release 0.4.9
7657e41 
- Migrate to pin-project-lite ([#595])
- **builder**: Implement `Layer` for `ServiceBuilder` ([#600])
- **builder**: Add `ServiceBuilder::and_then` analogous to
  `ServiceExt::and_then` ([#601])

[#600]: #600
[#601]: #601
[#595]: #595
[pin-project-lite]: https://crates.io/crates/pin-project-lite
@davidpdrsn davidpdrsn mentioned this pull request Oct 13, 2021
Merged
davidpdrsn added a commit that referenced this pull request Oct 14, 2021
@davidpdrsn
tower: prepare to release 0.4.9 (#602)
62e0902 
- Migrate to pin-project-lite ([#595])
- **builder**: Implement `Layer` for `ServiceBuilder` ([#600])
- **builder**: Add `ServiceBuilder::and_then` analogous to
  `ServiceExt::and_then` ([#601])

[#600]: #600
[#601]: #601
[#595]: #595
[pin-project-lite]: https://crates.io/crates/pin-project-lite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

@hawkw hawkw Awaiting requested review from hawkw

@carllerche carllerche Awaiting requested review from carllerche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidpdrsn @jonhoo