Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked package versions for tower packages and new app packages #392

Merged
merged 1 commit into from Mar 15, 2013

Conversation

btbinhtran
Copy link
Contributor

I've locked the package versions in the tower source to make it easier for new contributors to setup when they link tower.

lancejpollard added a commit that referenced this pull request Mar 15, 2013
Locked package versions for tower packages and new app packages
@lancejpollard lancejpollard merged commit 935a8f8 into tower:master Mar 15, 2013
@lancejpollard
Copy link
Member

Thank you!

@pocesar
Copy link

pocesar commented Mar 17, 2013

this is no use if the generated package.json from tower new app is not locked, it's still generating dependencies with >=, had to manually lock them, but most users won't take notice before doing an npm install

@btbinhtran
Copy link
Contributor Author

tower new app is generating dependencies with ~.
Check the files changed 935a8f8

Make sure tower is linked properly with npm link in the tower source directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants