Label atomic procedures as "define (no refresh)" #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towerofnix
reviewed
Feb 18, 2017
src/blocks/Block.as
Outdated
| @@ -41,6 +41,7 @@ import flash.filters.GlowFilter; | |||
| import flash.geom.*; | |||
| import flash.net.URLLoader; | |||
| import flash.text.*; | |||
| import flash.external.ExternalInterface; | |||
There was a problem hiding this comment.
That was for console.logging and I forgot to remove it. Whoops
There was a problem hiding this comment.
Wow, not using DialogBox.notify as your main logging system!? 🌈
| @@ -594,6 +596,7 @@ public class Block extends Sprite { | |||
| dup.parameterNames = parameterNames; | |||
| dup.defaultArgValues = defaultArgValues; | |||
| dup.warpProcFlag = warpProcFlag; | |||
| dup.setSpec(newSpec); | |||
There was a problem hiding this comment.
Is there any reason for this?
There was a problem hiding this comment.
Yep! Otherwise "no refresh" doesn't show up in the scrap block pane thingy script browser because the blockspec never gets reloaded when its in that pane, just duplicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21.