Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator for object detection with yolo #172

Closed
wants to merge 1 commit into from
Closed

Add operator for object detection with yolo #172

wants to merge 1 commit into from

Conversation

shiyu22
Copy link
Contributor

@shiyu22 shiyu22 commented Oct 12, 2021

Signed-off-by: shiyu22 shiyu.chen@zilliz.com

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiyu22
To complete the pull request process, please assign junjiejiangjjj after the PR has been reviewed.
You can assign the PR to them by writing /assign @junjiejiangjjj in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shiyu22
Copy link
Contributor Author

shiyu22 commented Oct 12, 2021

@fzliu It shows the error ModuleNotFoundError: No module named 'cv2', how can I install the package?

@filip-halt
Copy link
Contributor

@fzliu It shows the error ModuleNotFoundError: No module named 'cv2', how can I install the package?

I think you can download it using pip install opencv-python

@shiyu22
Copy link
Contributor Author

shiyu22 commented Oct 13, 2021

I think you can download it using pip install opencv-python

I see, actually I write a requirements.txt for the package, but I don't know how to run it in the CI Workflow.

Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>

Delete useless parameter

Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>

Delete black line

Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>

Update quote delimiter

Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>

Add requires

Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>
@codecov-commenter
Copy link

Codecov Report

Merging #172 (ffe0574) into main (f821795) will decrease coverage by 4.07%.
The diff coverage is 36.00%.

❗ Current head ffe0574 differs from pull request most recent head 99830e3. Consider uploading reports for the commit 99830e3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   77.81%   73.73%   -4.08%     
==========================================
  Files          90       93       +3     
  Lines        3282     3488     +206     
  Branches      331      360      +29     
==========================================
+ Hits         2554     2572      +18     
- Misses        600      787     +187     
- Partials      128      129       +1     
Impacted Files Coverage Δ
...etector_operator/pytorch_yolo_detector_operator.py 36.00% <36.00%> (ø)
towhee/engine/pipeline.py 73.33% <0.00%> (-17.58%) ⬇️
towhee/__init__.py 90.90% <0.00%> (-4.33%) ⬇️
towhee/engine/operator_context.py 95.89% <0.00%> (-0.11%) ⬇️
...h_transform_operator/pytorch_transform_operator.py 100.00% <0.00%> (ø)
...operators/norm_data_operator/norm_data_operator.py 58.33% <0.00%> (ø)
towhee/utils/hub_tools.py 0.00% <0.00%> (ø)
towhee/engine/task.py 100.00% <0.00%> (+9.52%) ⬆️
towhee/utils/handler_mixin.py 81.25% <0.00%> (+14.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f821795...99830e3. Read the comment docs.

@shiyu22
Copy link
Contributor Author

shiyu22 commented Oct 19, 2021

I have loaded the Operator and Pipeline to the Towhee hub and close it.

@shiyu22 shiyu22 closed this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants