Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semi-circular import issue in python3.6 #311

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

Chiiizzzy
Copy link
Contributor

@Chiiizzzy Chiiizzzy commented Dec 6, 2021

In towhee/engine/operator_io, import reader and writer in init.py, should use

from towhee.engine.operator_io import reader as io_reader
from towhee.engine.operator_io import writer as io_writer

instead of

import towhee.engine.operator_io.reader as io_reader
import towhee.engine.operator_io.writer as io_writer

which cause error in python 3.6

@codecov-commenter
Copy link

Codecov Report

Merging #311 (e11c896) into main (fbfd4dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   70.46%   70.46%           
=======================================
  Files         209      209           
  Lines        7573     7573           
  Branches     1004     1004           
=======================================
  Hits         5336     5336           
  Misses       1984     1984           
  Partials      253      253           
Impacted Files Coverage Δ
towhee/engine/operator_io/__init__.py 78.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfd4dd...e11c896. Read the comment docs.

@fzliu
Copy link
Member

fzliu commented Dec 6, 2021

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Chiiizzzy, fzliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants