Port fix #1
Port fix #1
Conversation
…andom port and register that with the proxy.
|
If you think this is ok, could you merge it to your master and let's ping felixbecker again? I'd really like this to land in the official plugin. |
|
From a quick gander, it appears that these changes would require an update or two to the corresponding tests. @zobo @towhidabsar thoughts? |
|
I did some small updates to tests so that they should still work, but did not introduce any new ones. Will look at it, but as the upstream author isn't reponding much... |
|
Sorry didn't get a chance to look into it. I will take a look at it and put in my feedback by end of day tomorrow. Thanks for the patience. |
|
Looked at it again, and not really sure what extra tests you had in mind. The dynamic port can hardly be tested, as it's not even exported back out of class. If you have a specific wish let me know and I'll try to work on it. |
zobo
force-pushed
the
port-fix
branch
11 times, most recently
from
e82e8ee
to
bf4648c
Compare
zobo
force-pushed
the
port-fix
branch
6 times, most recently
from
8ee8e2a
to
8e81d9c
Compare
…cos build. Removing unsupported windows build versions.
Fixed the fact that the proxy port was registered to proxy instead of the ide port.
Implemented random ide port if no specific port is set (or zero).