Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add ability for generals to add/remove nation military ranks #118

Closed
Goosius1 opened this issue Feb 10, 2021 · 3 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@Goosius1
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  • Currently, only kings/assistants can add/remove nation military ranks
  • Thus, soldier recruitment has to wait for the king to come online, and if a soldier is behaving with poor discipline and dying a lot, affecting a siege badly, again the king has to come online to remove their rank.

Describe the solution you'd like

  • It would be beneficial if generals could add/remove military ranks
  • Thus generals could get a new permission: towny.nation.siege.rank.* ........can add/remove ranks which have towny.nation.siege.points (but not ranks w/ towny.nation.siege.*)

Describe alternatives you've considered

  • I considered giving generals the overall nation rank permission ..... but this would effectively make them as powerful as assistants.....which is often not appropriate.

Additional context
N/A

@Goosius1 Goosius1 added the enhancement New feature or request label Feb 10, 2021
@Warriorrrr
Copy link
Member

I think this can be done very easily, looking at the code for the /n rank add command in Towny, if the general was given the permission node "towny.command.nation.rank.soldier", that would allow them to add others as soldiers.

@Goosius1
Copy link
Collaborator Author

Wow great thanks!, I'll test that out later so. If that works we'll be able to just add that to the install guide and then close the ticket.

@Goosius1
Copy link
Collaborator Author

I tested it. It works thanks!.

  • I will add this as an install step
  • I will also add to documentation: Just add this to the general rank: "towny.command.nation.rank.soldier"
  • I will also add this to a release instructions section for next release
  • I will also add this issue to the milestone, to further increase visibility

@Goosius1 Goosius1 added this to the 0.1.2 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants