Create parent directories if necessary #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-commit CI failure seems to be exactly this; let me know how you want me to proceed. |
|
Let's do pathlib 😊 |
for more information, see https://pre-commit.ci
Thanks, done! |
TheMatt2
pushed a commit
to TheMatt2/py-filelock
that referenced
this pull request
Jul 29, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176
Implements @gaborbernat's #176 (comment); i.e., creates any necessary parent directories on
acquireso that theopencall doesn't cause aFileNotFoundErrorif those directories do not exist.This could also be done using
pathlib, but I chose to useosfor consistency with the rest of the package. Also, I haven't tested if the change is actually needed on Windows too (I've made the same change towindows.pyanyway).