-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have duplicate metadata and invalid req strings honor --warn option #357
Conversation
Still working on this, I'll see if I can finish this and open it for review by the end of today. |
More specifically, the duplicate metadata and invalid req string warnings.
4a4f201
to
e2e0d12
Compare
Did a redesign and this seems to be a better implementation than the last. Just need to add coverage tests then I'll open this PR for review |
I think this is ready to go, going to open this for review |
Here are my design decisions:
|
Ignore my previous deleted comment, I've reconsidered and the handling of "duplicated" here should be fine. |
No questions for me here. But I don't have the approve auth, so maybe need to wait for @gaborbernat to take a further look. |
Great, will release 2.19.0 after merging this |
This resolves #355 by making changes and refactors to the warning logic. It does so by introducing a module-level singleton "WarningPrinter" object and refactors the code in such a way to integrate this object for it to be used.