Properly pickle of Timeout objects + test cases #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout now registers a __reduce__() function to allow for proper pickling. Tests check Timeout object has proper attributes and pickle successfully.
for more information, see https://pre-commit.ci
Well... looks like I have some type checking to work out... |
pyupgrade forced the new type syntax, so remove the old import
Add type: ignore to Timeout so mypy strict checking passes. The code already sets the types as one would expect. However, OSError does not appear to be annotated, making mypy unhappy.
for more information, see https://pre-commit.ci
Well... ok then |
PEP8 says inline comments should be preceded by at least 2 spaces
Clearly marked "timeout_1" and "timeout_2" instead of "timeout" and "timeout2"
…into bugfix-202
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
gaborbernat
approved these changes
Mar 22, 2023
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
matfax
pushed a commit
to matfax/mutapath
that referenced
this pull request
Jul 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [filelock](https://togithub.com/tox-dev/py-filelock) | `3.0.12` -> `3.12.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/py-filelock (filelock)</summary> ### [`v3.12.2`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.12.2) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.12.1...3.12.2) #### What's Changed - Restore 'if TYPE_CHECKING' syntax for FileLock definition by [@​dlax](https://togithub.com/dlax) in [tox-dev/filelock#245 #### New Contributors - [@​dlax](https://togithub.com/dlax) made their first contribution in [tox-dev/filelock#245 **Full Changelog**: tox-dev/filelock@3.12.1...3.12.2 ### [`v3.12.1`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.12.1) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.12.0...3.12.1) ##### What's Changed - Add trusted-publish by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#236 - Add 3.12 support by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#237 - Bump pypa/gh-action-pypi-publish from 1.8.5 to 1.8.6 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#239 - git ls-files -z -- .github/workflows/check.yml | xargs -0 sed -i 's|3.12.0-alpha.7|3.12.0-beta.1|g' by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#243 - Use ruff by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#244 - Fix test_bad_lock_file for other OSes by [@​TheMatt2](https://togithub.com/TheMatt2) in [tox-dev/filelock#242 **Full Changelog**: tox-dev/filelock@3.12.0...3.12.1 ### [`v3.12.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.12.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.11.0...3.12.0) #### What's Changed - Fix: [#​225](https://togithub.com/tox-dev/py-filelock/issues/225) :Get rid of warning about inability to link to \_thread.\_local. by [@​csm10495](https://togithub.com/csm10495) in [tox-dev/filelock#226 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#228 - Add umask check to tests so umask 002 is valid by [@​TheMatt2](https://togithub.com/TheMatt2) in [tox-dev/filelock#227 - Fix lock hang on Windows by [@​TheMatt2](https://togithub.com/TheMatt2) in [tox-dev/filelock#231 - Conditionally disable/enable thread-local lock behavior. by [@​csm10495](https://togithub.com/csm10495) in [tox-dev/filelock#232 **Full Changelog**: tox-dev/filelock@3.11.0...3.12.0 ### [`v3.11.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.11.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.7...3.11.0) #### What's Changed - Bump pypa/gh-action-pypi-publish from 1.8.3 to 1.8.5 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#218 - Fix [#​220](https://togithub.com/tox-dev/py-filelock/issues/220): Allow filelock test thread to catch any exceptions by [@​TheMatt2](https://togithub.com/TheMatt2) in [tox-dev/filelock#221 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#222 - Run more pypy versions in CI but without coverage by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#224 - Make the lock a thread local variable by [@​csm10495](https://togithub.com/csm10495) in [tox-dev/filelock#219 #### New Contributors - [@​csm10495](https://togithub.com/csm10495) made their first contribution in [tox-dev/filelock#219 **Full Changelog**: tox-dev/filelock@3.10.7...3.11.0 ### [`v3.10.7`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.7) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.6...3.10.7) #### What's Changed - use fchmod by [@​jfennick](https://togithub.com/jfennick) in [tox-dev/filelock#214 #### New Contributors - [@​jfennick](https://togithub.com/jfennick) made their first contribution in [tox-dev/filelock#214 **Full Changelog**: tox-dev/filelock@3.10.6...3.10.7 ### [`v3.10.6`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.6) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.5...3.10.6) #### What's Changed - Bugfix/147 by [@​jahrules](https://togithub.com/jahrules) in [tox-dev/filelock#213 **Full Changelog**: tox-dev/filelock@3.10.5...3.10.6 ### [`v3.10.5`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.5) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.4...3.10.5) #### What's Changed - proposed fix for issue [#​67](https://togithub.com/tox-dev/py-filelock/issues/67) by [@​jahrules](https://togithub.com/jahrules) in [tox-dev/filelock#212 **Full Changelog**: tox-dev/filelock@3.10.4...3.10.5 ### [`v3.10.4`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.4) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.3...3.10.4) #### What's Changed - updated os.open to preserve mode by [@​jahrules](https://togithub.com/jahrules) in [tox-dev/filelock#211 **Full Changelog**: tox-dev/filelock@3.10.3...3.10.4 ### [`v3.10.3`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.3) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.2...3.10.3) #### What's Changed - Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#207 - bug fix by [@​jahrules](https://togithub.com/jahrules) in [tox-dev/filelock#209 **Full Changelog**: tox-dev/filelock@3.10.2...3.10.3 ### [`v3.10.2`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.2) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.1...3.10.2) #### What's Changed - changed from os.umask to os.chmod by [@​jahrules](https://togithub.com/jahrules) in [tox-dev/filelock#206 **Full Changelog**: tox-dev/filelock@3.10.1...3.10.2 ### [`v3.10.1`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.1) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.10.0...3.10.1) #### What's Changed - Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#200 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#201 - Properly pickle of Timeout objects + test cases by [@​TheMatt2](https://togithub.com/TheMatt2) in [tox-dev/filelock#203 #### New Contributors - [@​TheMatt2](https://togithub.com/TheMatt2) made their first contribution in [tox-dev/filelock#203 **Full Changelog**: tox-dev/filelock@3.10.0...3.10.1 ### [`v3.10.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.10.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.9.1...3.10.0) #### What's Changed - added multiuser support and associated tests by [@​jahrules](https://togithub.com/jahrules) in [tox-dev/filelock#192 #### New Contributors - [@​jahrules](https://togithub.com/jahrules) made their first contribution in [tox-dev/filelock#192 **Full Changelog**: tox-dev/filelock@3.9.1...3.10.0 ### [`v3.9.1`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.9.1) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.9.0...3.9.1) #### What's Changed - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#188 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#193 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#197 - Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#198 - use time.perf_counter instead of time.monotonic by [@​zpz](https://togithub.com/zpz) in [tox-dev/filelock#194 #### New Contributors - [@​zpz](https://togithub.com/zpz) made their first contribution in [tox-dev/filelock#194 **Full Changelog**: tox-dev/filelock@3.9.0...3.9.1 ### [`v3.9.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.9.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.8.2...3.9.0) #### What's Changed - Move to hatchling build backend by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#185 **Full Changelog**: tox-dev/filelock@3.8.2...3.9.0 ### [`v3.8.2`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.8.2) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.8.1...3.8.2) #### What's Changed - Bump pypa/gh-action-pypi-publish from 1.5.1 to 1.6.1 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#178 - Update the license classifier to "Unlicense" by [@​jond01](https://togithub.com/jond01) in [tox-dev/filelock#180 #### New Contributors - [@​jond01](https://togithub.com/jond01) made their first contribution in [tox-dev/filelock#180 **Full Changelog**: tox-dev/filelock@3.8.1...3.8.2 ### [`v3.8.1`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.8.1) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.8.0...3.8.1) #### What's Changed - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#166 - link to flufl.lock by [@​dholth](https://togithub.com/dholth) in [tox-dev/filelock#167 - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#168 - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#169 - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#170 - fix BaseFileLock.timeout's getter/setter being obscured by itself by [@​dearfl](https://togithub.com/dearfl) in [tox-dev/filelock#172 - Fix mypy fails understanding FileLock by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#177 #### New Contributors - [@​dholth](https://togithub.com/dholth) made their first contribution in [tox-dev/filelock#167 - [@​dearfl](https://togithub.com/dearfl) made their first contribution in [tox-dev/filelock#172 **Full Changelog**: tox-dev/filelock@3.8.0...3.8.1 ### [`v3.8.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.8.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.7.1...3.8.0) #### What's Changed - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#149 - Bump actions/upload-artifact from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#154 - Bump actions/download-artifact from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#152 - Bump pre-commit/action from 2.0.3 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#151 - Bump actions/checkout from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#153 - Bump actions/setup-python from 2 to 4 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/filelock#150 - Add timeout unit to docstrings by [@​jnordberg](https://togithub.com/jnordberg) in [tox-dev/filelock#148 - Unify badges style by [@​DeadNews](https://togithub.com/DeadNews) in [tox-dev/filelock#155 - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#156 - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#157 - Check 3.11 support by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#158 - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#159 - Bump dependencies by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/filelock#160 - \[pre-commit.ci] pre-commit autoupdate by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [tox-dev/filelock#162 #### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [tox-dev/filelock#154 - [@​jnordberg](https://togithub.com/jnordberg) made their first contribution in [tox-dev/filelock#148 - [@​DeadNews](https://togithub.com/DeadNews) made their first contribution in [tox-dev/filelock#155 **Full Changelog**: tox-dev/filelock@3.7.1...3.8.0 ### [`v3.7.1`](https://togithub.com/tox-dev/py-filelock/compare/3.7.0...3.7.1) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.7.0...3.7.1) ### [`v3.7.0`](https://togithub.com/tox-dev/py-filelock/compare/3.6.0...3.7.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.6.0...3.7.0) ### [`v3.6.0`](https://togithub.com/tox-dev/py-filelock/compare/3.5.1...3.6.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.5.1...3.6.0) ### [`v3.5.1`](https://togithub.com/tox-dev/py-filelock/compare/3.5.0...3.5.1) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.5.0...3.5.1) ### [`v3.5.0`](https://togithub.com/tox-dev/py-filelock/compare/3.4.2...3.5.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.4.2...3.5.0) ### [`v3.4.2`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.4.2): Drop Python 3.6 support [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.4.1...3.4.2) ### [`v3.4.1`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.4.1): Add stacklevel to deprecation warnings for argument name change [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.4.0...3.4.1) ### [`v3.4.0`](https://togithub.com/tox-dev/py-filelock/compare/3.3.2...3.4.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.3.2...3.4.0) ### [`v3.3.2`](https://togithub.com/tox-dev/py-filelock/compare/3.3.1...3.3.2) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.3.1...3.3.2) ### [`v3.3.1`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.3.1): Keep filelock logger as not set [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.3.0...3.3.1) ### [`v3.3.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.3.0): Drop python 2.7+3.5 support and add type annotations [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.2.1...3.3.0) ### [`v3.2.1`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.2.1): New documentation and enable logging of our logger on debug level [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.2.0...3.2.1) ### [`v3.2.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.2.0) [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/3.1.0...3.2.0) 1. [#​96](https://togithub.com/tox-dev/py-filelock/issues/96) - Raise when trying to acquire in R/O or missing folder 2. [#​95](https://togithub.com/tox-dev/py-filelock/issues/95) - Move log from info to debug ### [`v3.1.0`](https://togithub.com/tox-dev/py-filelock/releases/tag/3.1.0): Move from module file to package [Compare Source](https://togithub.com/tox-dev/py-filelock/compare/v3.0.12...3.1.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matfax/mutapath). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for bug #202.
Timeout now registers a
__reduce__()function to allow for proper pickling.Tests check
Timeoutobject has proper attributes and pickle successfully.