Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maturin to build release #1

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

gaborbernat
Copy link
Member

Signed-off-by: Bernát Gábor bgabor8@bloomberg.net

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit f25874e into tox-dev:main May 10, 2024
31 checks passed
@henryiii
Copy link
Contributor

How did this compare? I came here to try musllinux_1_2, which I found out we support, but guess I'll have to look elsewhere to update pypa/cibuildwheel#1816.

@gaborbernat
Copy link
Member Author

From 12 minutes down to 3 with more wheel types https://github.com/tox-dev/pyproject-fmt-rust/actions/runs/9040915345

@henryiii
Copy link
Contributor

You are building each in a separate job, not sure that's a perfectly fair comparison. cibuildwheel could be split up too, it can even generate the job matrix for you (with a little json wrangling). Maturin is downloading the manylinux docker too, so I expect it's pretty similar for similar jobs. Though I think you can disable the manylinux image with Maturin-action if you don't need it, which usually you don't, from what I gather.

Though those special archs will be much slower in cibuildwheel, as it would use emulation instead of cross-compiling.

I just was testing musl, it seems like it works on 1_1, even if Rust was built with 1.2, you just can't do 32-bit without cross-compiling, which cibuildwheel can't do. Can the maturin action do musllinux? I don't see that in the output wheels.

@gaborbernat
Copy link
Member Author

Oh, I am not saying it was fair, but was faster and quicker to set up, part of that was just that maturin generates the CI config for you. maturin generate-ci github

@gaborbernat
Copy link
Member Author

Can the maturin action do musllinux? I don't see that in the output wheels.

I think is missing for now, though there's mention of it at https://www.maturin.rs/distribution

@henryiii
Copy link
Contributor

It can, I've got both musllinux_1_2 wheels building now. Trying to see if I can get 1_1, though. (not that it likely matters here, but I want uv to support 1_1 so we can put it in manylinux, and this is a good learning project to try it in) :).

@gaborbernat
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants