ci: add musllinux_1_1 wheels #3
Conversation
| matrix: | ||
| platform: | ||
| - runner: ubuntu-latest | ||
| target: x86_64 | ||
| - runner: ubuntu-latest | ||
| target: x86 | ||
| - runner: ubuntu-latest |
There was a problem hiding this comment.
Can you please update the cargo and project.toml file to 1.0.2 😅
There was a problem hiding this comment.
Can't Maturin read the version number from Cargo.toml?
There was a problem hiding this comment.
I didn't see a way to do that so unless I'm blind I feel not...
There was a problem hiding this comment.
It's listed in both dynamic and directly, that's incorrect. Will try removing from pyproject.toml, it says in the docs that they are merged.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/ci/try-musl2
branch
from
305685c
to
9cfc915
Compare
| @@ -6,7 +6,6 @@ requires = [ | |||
|
|
|||
| [project] | |||
| name = "pyproject-fmt-rust" | |||
| version = "1.0.1" | |||
There was a problem hiding this comment.
Do you have a link where they say you can do that? 🤣 At the very least the version should be dynamic otherwise it's violating pep 621...
There was a problem hiding this comment.
It is. Check below. ;) It previously was violating PEP 621 by having both static and dynamic versions.
https://www.maturin.rs/metadata (at the top)
There was a problem hiding this comment.
I can't comment on it, but see line 32.
This adds musllinux, and since I figured out how to target 1_1, went ahead and targeted it here.
By the way, the i686 manglinux wheel is getting tagged as manylinux1, while all the others are getting the (correct) manylinux2014 tags. Not sure why it would be different.