Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare extension safe for parallel reads #171

Merged

Conversation

JSCU-CNI
Copy link
Contributor

This PR should fix the following Sphinx warning and make the extension faster.

WARNING: the sphinx_argparse_cli extension does not declare if it is safe for parallel reading, assuming it isn't - please ask the extension author to check and make it explicit
WARNING: doing serial read

This commit is essentially the same as tox-dev/sphinx-autodoc-typehints#9 / c4657bc57a290a79605ed86398db28419aabfbb9.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test please

@JSCU-CNI
Copy link
Contributor Author

Test please

Existing tests seem to pass, what exactly would you like to test further?

@gaborbernat gaborbernat merged commit fb59f64 into tox-dev:main Jun 18, 2024
8 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/setup-parallel-read-dict branch June 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants