Add type hints for attributes #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there are test failures which you should fix. Also, please add a blank line after every control block. |
gaborbernat
force-pushed
the
attr-typehints
branch
from
3da3f3f
to
c3211b3
Compare
|
@david-yan I've rebased on main, can you please fix the CI, thanks! |
|
Closing due to inactivity, please reopen a new PR in case you'd like to pick it up again. Thanks for the understanding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening https://github.com/agronholm/sphinx-autodoc-typehints/pull/143 with a new branch.
Partially resolves #44, although not for inline comments.