Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to force unions (and options) to be rendered with bars #418

Merged
merged 9 commits into from Feb 8, 2024

Conversation

hoodmane
Copy link
Collaborator

Resolves #413.

@gaborbernat gaborbernat marked this pull request as draft January 23, 2024 01:07
@gaborbernat
Copy link
Member

@hoodmane do you plan to pick this up again?

@hoodmane hoodmane marked this pull request as ready for review February 7, 2024 23:09
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI still failing 😢

@hoodmane
Copy link
Collaborator Author

hoodmane commented Feb 8, 2024

Oh right. I fixed the tests but then Make always_use_bars_union on by default broke them again.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 601583f into tox-dev:main Feb 8, 2024
10 checks passed
@hoodmane hoodmane deleted the always-bars-union branch February 8, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render union types using |
4 participants