Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tox casing #107

Merged
merged 2 commits into from
Sep 14, 2018
Merged

fix tox casing #107

merged 2 commits into from
Sep 14, 2018

Conversation

obestwalter
Copy link
Member

tox is all lower case. Always. Everywhere.

Plugin names are also just lower case.

Thanks for tolerating my tox lower case obsession :)

tox is all lower case. Always. Everywhere.

Plugin names are also just lower case.

Thanks for tolerating my tox lower case obsession :)
Copy link
Collaborator

@ryanhiebert ryanhiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. The build needs to get fixed before it's merged, though. Has to do with Python 3.3 support being dropped in Tox. I think that we'll want to go ahead and drop support for Python 3.3 for tox-travis as well, but let's do that in another PR. We'll also need to address that Python 3.3 is the only pypy3 that we currently test at the same time, and figure out what tests we should be keeping in mind for pypy3 in the future.

@obestwalter
Copy link
Member Author

Hi @ryanhiebert, o.k. - so the PR can just hang around till then or is there something I can do?

@ryanhiebert
Copy link
Collaborator

It can hang around. If you feel like looking into adding newer pypy3 to the build and removing support for all Python 3.3 implementations, I'd be happy for a PR. I can't guarantee when I'll get to it, I've been kinda slammed recently.

@ryanhiebert ryanhiebert merged commit d2692de into master Sep 14, 2018
@ryanhiebert ryanhiebert deleted the tox-all-lowercase branch September 14, 2018 11:58
@ryanhiebert
Copy link
Collaborator

It's about time I got to this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants