Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update py34 -> py37 #131

Closed
wants to merge 8 commits into from
Closed

Update py34 -> py37 #131

wants to merge 8 commits into from

Conversation

chenrui333
Copy link

docs/envlist.rst Outdated Show resolved Hide resolved
@chenrui333
Copy link
Author

chenrui333 commented Jun 2, 2019

@gaborbernat
Copy link
Member

Just drop python 2.6 👍

@gaborbernat
Copy link
Member

Now we just need to fix the tests failing 👍

@chenrui333
Copy link
Author

that is right 😄

@ryanhiebert
Copy link
Collaborator

The thinking behind this is good, though not urgent. Let's keep dropping py34 as a separate issue. And I delayed this enough that it really should be adjusting to 3.8. I'm going to close it, but new PRs dealing with this are welcome. Thank you, @chenrui333 !

@chenrui333
Copy link
Author

I will find some time to take another look on this, sorry for the long delay. :)

@ryanhiebert
Copy link
Collaborator

The delay was me, not you, so the apology is mine. Anyway, I finally got to some stuff in this repo, but this ended up not cleaning up as easily as the other PRs, so I concluded that it would be best to go ahead and let you figure out what of it still applied how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants