Allow PyPy3 support to work with PyPy3 5.5 #66
Conversation
src/tox_travis/toxenv.py
Outdated
| @@ -46,7 +46,7 @@ def default_toxenv(): | |||
| # https://github.com/travis-ci/travis-ci/issues/6304 | |||
| # Force use of the virtualenv `python`. | |||
| version = os.environ.get('TRAVIS_PYTHON_VERSION') | |||
| if version and default_factors and version.startswith('pypy3.3-5.2-'): | |||
| if version and default_factors and re.match(r'pypy-3\.3-5\.\d-', version): | |||
There was a problem hiding this comment.
I totally missed it on the first review. Thank goodness for automated testing.
In the translation to using re.match you've added a dash after pypy, which is making it not match the already existing version.
There was a problem hiding this comment.
Hmm. I think that just using version.startswith('pypy3.3-') might work. I'm inclined to try that.
|
Thank you for your work on this, @kirbyfan64. I'm doing all this on borrowed computers at the moment, so if you're able to update the pull request that would be very helpful. I think I'll be able to make a release without needing a decent terminal, so I should be good there. |
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
======================================
Coverage 75.4% 75.4%
======================================
Files 4 4
Lines 187 187
Branches 46 46
======================================
Hits 141 141
Misses 38 38
Partials 8 8
Continue to review full report at Codecov.
|
|
Project coverage is the same, so this already wasn't covered. The build matrix is passing, so technically it is covered in some way, just not a way that's being reported to codecov. |
|
Might be a few days before I release, but thank you very much for your help, @kirbyfan64 ! |
|
I'm working on cutting a release now. I didn't realize that this hadn't been released yet. I'm sorry, folks. |
|
0.9 is out! |
Closes #65.