Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename toxenv files to envlist #83

Merged
merged 9 commits into from
Nov 11, 2017
Merged

Rename toxenv files to envlist #83

merged 9 commits into from
Nov 11, 2017

Conversation

ryanhiebert
Copy link
Collaborator

Fixes #80

@codecov-io
Copy link

codecov-io commented Nov 4, 2017

Codecov Report

Merging #83 into master will increase coverage by 5.73%.
The diff coverage is 87.09%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #83      +/-   ##
=======================================
+ Coverage   77.27%   83%   +5.73%     
=======================================
  Files           5     5              
  Lines         198   206       +8     
  Branches       46    48       +2     
=======================================
+ Hits          153   171      +18     
+ Misses         38    29       -9     
+ Partials        7     6       -1
Impacted Files Coverage Δ
src/tox_travis/envlist.py 94.93% <100%> (ø)
src/tox_travis/after.py 70.93% <75%> (+13.09%) ⬆️
src/tox_travis/hooks.py 92.59% <88.88%> (+5.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe8441...8bbd92a. Read the comment docs.

@rpkilby
Copy link
Member

rpkilby commented Nov 4, 2017

Two thoughts:

  • A part of my says the output should be tested for the warnings, but it seems straightforward enough to honestly not warrant tests.
  • Would it make sense to name the files envlist instead of detect? eg,
    from envlist import detect_envlist

Those considerations aside, 👍

@ryanhiebert
Copy link
Collaborator Author

ryanhiebert commented Nov 4, 2017

Yeah, I've got to figure out how to test this section. Right now the after feature is considered "experimental", so I don't have it fully tested (especially the hooks and monkeypatch).

envlist was the original plan, as I specified on #80. My main driver for doing something different was #84, considering how I'd like to spell that flag. I like --auto-envlist less than --detect, and --envlist isn't a clear option IMO. Avoiding multiple words was something that I liked with --detect. Perhaps the flag needs to be --detect-envlist (or the negative). In that case it would be multiple words, but I'd have no issue renaming the files to envlist then.

@ryanhiebert
Copy link
Collaborator Author

As I noted on #84, envlist is a good name for the feature, so I've updated this PR to use envlist as the name that we're renaming toxenv to.

@ryanhiebert
Copy link
Collaborator Author

I'm glad that I added tests for the changes in travis:after. There were some bugs that needed to be addressed.

@ryanhiebert ryanhiebert changed the title Rename toxenv files to detect Rename toxenv files to envlist Nov 11, 2017
@ryanhiebert ryanhiebert merged commit d160ba8 into master Nov 11, 2017
@ryanhiebert ryanhiebert deleted the detect branch November 11, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants