add safety wrapper around sys.stdout assignment

See #723 for bug details
tox-dev · Jan 4, 2018 · 69e05ac · 69e05ac
1 parent 33b3fe8
commit 69e05ac
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/tox/venv.py b/tox/venv.py
@@ -303,9 +303,11 @@ def run_install_command(self, packages, action, options=()):
 
         old_stdout = sys.stdout
         sys.stdout = codecs.getwriter('utf8')(sys.stdout)
-        self._pcall(argv, cwd=self.envconfig.config.toxinidir, action=action,
-                    redirect=self.session.report.verbosity < 2)
-        sys.stdout = old_stdout
+        try:
+            self._pcall(argv, cwd=self.envconfig.config.toxinidir,
+                        action=action, redirect=self.session.report.verbosity < 2)
+        finally:
+            sys.stdout = old_stdout
 
     def _install(self, deps, extraopts=None, action=None):
         if not deps: