Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] venv provisioning seems to enter an infinite loop under Python 3.8 with virtualenv==20.0.1 when pip is in requires #1518

Closed
webknjaz opened this issue Feb 11, 2020 · 7 comments
Labels
bug:normal affects many people or has quite an impact

Comments

@webknjaz
Copy link
Contributor

CI log: https://github.com/ansible/ansible-lint/pull/637/checks?check_run_id=438702207#step:6:30

[tox]
...
requires =
  pip >= 19.3.0
$ TOXENV=docs python -m tox --parallel auto --notest
.tox create: /home/runner/work/ansible-lint/ansible-lint/.tox/.tox
.tox installdeps: setuptools >= 41.4.0, pip >= 19.3.0, tox >= 3.5.3
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.1/x64/lib/python3.8/runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.8.1/x64/lib/python3.8/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/__main__.py", line 4, in <module>
    tox.cmdline()
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/session/__init__.py", line 44, in cmdline
    main(args)
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/session/__init__.py", line 64, in main
    config = load_config(args)
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/session/__init__.py", line 80, in load_config
    config = parseconfig(args)
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 266, in parseconfig
    ParseIni(config, config_file, content)
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1073, in __init__
    self.handle_provision(config, reader)
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1147, in handle_provision
    deps = self.ensure_requires_satisfied(config, requires_list, min_version)
  File "/home/runner/work/ansible-lint/ansible-lint/.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1193, in ensure_requires_satisfied
    raise tox.exception.Error(msg.format(sys.executable, missing_requirements))
tox.exception.Error: Error: break infinite loop provisioning within /home/runner/work/ansible-lint/ansible-lint/.tox/.tox/bin/python missing ['pip>=19.3.0']
$ python -m pip freeze --all
appdirs==1.4.3
filelock==3.0.12
packaging==20.1
pip==20.0.2
pluggy==0.13.1
py==1.8.1
pyparsing==2.4.6
setuptools==41.2.0
six==1.14.0
toml==0.10.0
tox==3.14.3
virtualenv==20.0.1
@webknjaz webknjaz added the bug:normal affects many people or has quite an impact label Feb 11, 2020
@webknjaz
Copy link
Contributor Author

Weirdly, another job in the same CI run doesn't explode like that: https://github.com/ansible/ansible-lint/pull/637/checks?check_run_id=438702342

@webknjaz
Copy link
Contributor Author

Hm... Looks like the common denominator is Python 3.8, other jobs seem to be unaffected.

webknjaz added a commit to ansible/ansible-lint that referenced this issue Feb 11, 2020
@webknjaz
Copy link
Contributor Author

@gaborbernat any ideas?

@gaborbernat
Copy link
Member

not at the moment 🤔

@webknjaz webknjaz changed the title [BUG] venv provisioning seems to enter an infinite loop with virtualenv==20.0.1 when pip is in requires [BUG] venv provisioning seems to enter an infinite loop under Python 3.8 with virtualenv==20.0.1 when pip is in requires Feb 11, 2020
@gaborbernat
Copy link
Member

Is this still on with 20.0.3?

@webknjaz
Copy link
Contributor Author

I'll check. It seemed to only be reproducible in GH Actions Workflows.

webknjaz added a commit to ansible/ansible-lint that referenced this issue Feb 13, 2020
@webknjaz
Copy link
Contributor Author

Alright, it doesn't crash anymore with virtualenv==20.0.3: https://github.com/ansible/ansible-lint/commit/6ebd391bc08c4c6d4b31e954b17ecdd045015f4c/checks.

Thanks, Bernát!

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug:normal affects many people or has quite an impact
Projects
None yet
Development

No branches or pull requests

2 participants