Better handling of set_env #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rewrite #1784 +/- ##
===========================================
+ Coverage 99.73% 99.75% +0.02%
===========================================
Files 134 137 +3
Lines 6775 6982 +207
Branches 646 678 +32
===========================================
+ Hits 6757 6965 +208
+ Misses 7 6 -1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaborbernat
force-pushed
the
ci
branch
3 times, most recently
from
be4e1b7
to
1263c20
Compare
|
Blocked on pypa/virtualenv#2046 |
- support set env values in env replacer - support using set env key-values within set env - if a set env refers to itself then the value will be the os.environ content if present (resolve circular dependency) - raise error if resolving replacements cause a circle Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
gaborbernat
force-pushed
the
ci
branch
2 times, most recently
from
2792f87
to
67416fe
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
This was referenced Jan 11, 2021
gaborbernat
added a commit
that referenced
this pull request
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1779.
Resolves #1776.
Also introduces a lot of other fixes for things without a ticket and discovered while fixing these.