Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document version 4 different behaviours #2578

Closed
jugmac00 opened this issue Dec 2, 2022 · 3 comments · Fixed by #2601
Closed

Document version 4 different behaviours #2578

jugmac00 opened this issue Dec 2, 2022 · 3 comments · Fixed by #2601
Assignees

Comments

@jugmac00
Copy link
Member

jugmac00 commented Dec 2, 2022

tox 3 behavior

❯ tox -e py3 tests/unittests/net/test_networkd.py

... works

tox 4 behavior

❯ tox4 -e py3 tests/unittests/net/test_networkd.py
usage: tox [-h] [--colored {yes,no}] [-v | -q] [-c file] [--workdir dir] [--root dir] [--runner {virtualenv}] [--version] [--no-provision [REQ_JSON]] [--no-recreate-provision] [-r] [-x OVERRIDE]
           {run,r,run-parallel,p,depends,de,list,l,devenv,d,config,c,quickstart,q,exec,e,legacy,le} ...
tox: error: unrecognized arguments: tests/unittests/net/test_networkd.py
hint: if you tried to pass arguments to a command use -- to separate them from tox ones

While I think the behavior for tox 4 is more correct, at least we need to document this incompatibility.

Repository for above snippets:
https://github.com/canonical/cloud-init

tox configuration
https://github.com/canonical/cloud-init/blob/7a93f1cad75715696227aa0893ff15156eaa7943/tox.ini#L140-L147

@gaborbernat
Copy link
Member

The hint after the error is the documentation itself, what more you want?

@jugmac00
Copy link
Member Author

jugmac00 commented Dec 2, 2022

I want a dedicated section in our documentation about expected incompatibilities, which a user can read in advance, so no trial and error is necessary. This might be a standalone section or part of the release notes for tox 4 - though I think a standalone section would make more sense as I expect this list will grow bigger once tox 4 gets more widely used.

@gaborbernat
Copy link
Member

gaborbernat commented Dec 2, 2022

You're free to open a PR for this 👌 I'll not make it a 4.0 release blocker though.

@gaborbernat gaborbernat added this to the 4.1 milestone Dec 2, 2022
@gaborbernat gaborbernat changed the title tox 4: different behavior when passing in options for e.g. the test runner Document version 4 different behaviours Dec 2, 2022
@jugmac00 jugmac00 self-assigned this Dec 6, 2022
jugmac00 added a commit to jugmac00/tox that referenced this issue Dec 6, 2022
jugmac00 added a commit to jugmac00/tox that referenced this issue Dec 6, 2022
jugmac00 added a commit to jugmac00/tox that referenced this issue Dec 6, 2022
jugmac00 added a commit to jugmac00/tox that referenced this issue Dec 6, 2022
gaborbernat pushed a commit that referenced this issue Dec 7, 2022
Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
Co-authored-by: Bernát Gábor <bgabor8@bloomberg.net>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Bernát Gábor <gaborjbernat@gmail.com>
Resolves #2578
Resolves #2602
Resolves #2608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants