Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unerstand "min_version = 4.0" from tox 3 or use "minversion = 4.0" in tox 4 documentation #2661

Closed
hroncok opened this issue Dec 9, 2022 · 6 comments

Comments

@hroncok
Copy link
Contributor

hroncok commented Dec 9, 2022

What's the problem this feature will solve?

Considering a new project follows the current documentation and they set:

[tox]
min_version = 4.0

When this is read by tox3, it is ignored, because tox3 only reads minversion, not min_version.
A project maintainer that knows this will adjust the config as follows:

[tox]
minversion = 4.0

This is respected by both tox3 and tox4, and hence it works.

However, a project maintainer who does not know this and tries to follow the documentation will be confused.

Describe the solution you'd like / Alternative Solutions

Either tox3 needs to be updated to also read min_version (this will work but only for users who have the latest version of tox3)
or the documentation needs to be updated to use minversion in the initial examples.

Users following the documentation for tox4 should be guided to create config files where the minial tox version requirement is respected in tox3 and tox4 both.

@gaborbernat
Copy link
Member

The without underscore version is kept for backwards compatibility and I don't want to encourage its use. So I don't want to do what you're asking. It's not our goal to create configurations going ahead that works for both tox 3 and 4. 3 is dead, let it die.

@gaborbernat gaborbernat closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2022
@gaborbernat
Copy link
Member

See https://tox.wiki/en/latest/config.html#min_version, specifying we support both, but the ordering is intentional.

@hroncok
Copy link
Contributor Author

hroncok commented Dec 10, 2022

It's not our goal to create configurations going ahead that works for both tox 3 and 4. 3 is dead, let it die.

My intention was to ease the transition to tox 4, not to create general configurations going ahead that work for both tox 3 and 4. Perhaps my wording was not good enough. Anyway, if you think that making the transition easier is not worth the trouble and we should rather let the users struggle with "why is this min_version thing from the example configuration not respected?" that's fine I guess. I am not happy about your decision, but I respect it.

@hroncok
Copy link
Contributor Author

hroncok commented Dec 10, 2022

The without underscore version is kept for backwards compatibility and I don't want to encourage its use.

The alternative is to backport the underscore version to a maintenance release of 3.

@gaborbernat
Copy link
Member

The transition path is to set min_version 4 and stop using version 3 😅 anything else is not supported. We plan to do no further development for version three.

@gaborbernat
Copy link
Member

@hroncok if you think this would be useful feel free to put in a PR against the legacy branch for min_version 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants