-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnicodeEncodeError during install_deps with emoji in git branch name #2768
Comments
Seems the branch is no longer valid 🤔 |
Yes sorry, the owner deleted it. I created my own here And here is the output with increased verbosity:
|
I'm having trouble reproducing this. Not getting these errors with an emoji branch name on my windows machine or in Github Actions. @zariiii9003, do you see any obvious deviations in this action run relative to your runs? |
Thanks for looking into this. I'm not sure if it's relevant, but i found a difference in the git checkout. The problematic character exists in my log:
but not in yours
|
Good eye! I'll dig into that. |
Shoot — still can't get it to error out. I renamed the main branch to https://github.com/jamwil/tox-2768-test/actions/runs/3801607129 |
Can you add Edit:
|
Beautiful—that caught it. I'll work on it. |
The fix is probably as simple as setting here https://github.com/tox-dev/tox/blob/main/src/tox/tox_env/api.py#L447 utf-8 as encoding for the file. |
Issue
The installation fails on Windows when there is an emoji in the git branch name.
See here. I'm not sure if it's a pip or tox error.
Here is the branch.
Environment
Provide at least:
Output of running tox
Provide the output of
tox -rvv
:The text was updated successfully, but these errors were encountered: