New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox 2.3 regression #294

Closed
pytoxbot opened this Issue Sep 17, 2016 · 6 comments

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

Hi,
At least two openstack project (Tempest and Nova) are hit by a regression introduced with Tox 2.3 released a couple of hours ago on pypi.

Here is a relevant stack trace:

#!shell

(toxtox)jordan@jordan-XPS13:/opt/stack/tempest (master %=)$ tox --version
2.3.0 imported from /opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/__init__.pyc
(toxtox)jordan@jordan-XPS13:/opt/stack/tempest (master %=)$ tox -epep8
Traceback (most recent call last):
  File "/opt/stack/tempest/toxtox/bin/tox", line 11, in <module>
    sys.exit(cmdline())
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/session.py", line 38, in main
    config = prepare(args)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/session.py", line 26, in prepare
    config = parseconfig(args)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 229, in parseconfig
    parseini(config, inipath)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 729, in __init__
    self.make_envconfig(name, section, reader._subs, config)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 760, in make_envconfig
    res = meth(env_attr.name, env_attr.default)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 893, in getdict_setenv
    definitions = self._getdict(value, default=default, sep=sep)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 904, in _getdict
    name, rest = line.split('=', 1)
ValueError: need more than 1 value to unpack

I think Tox failed on these lines:

#!shell

[testenv:all-plugin]
sitepackages = True
# 'all' includes slow tests
setenv = {[tempestenv]setenv}
         OS_TEST_TIMEOUT=1200
deps = {[tempestenv]deps}

Full tox.ini here: https://github.com/openstack/tempest/blob/02ef4c2956318b09cc47506af2361ab3d8907a10/tox.ini

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by jordan_pittier

Quick tests of tox-2.3.1 looks good. I think it's fixed for OpenStack.

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

let me know if tox-2.3.1 is stable again.

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fix issue294: re-allow cross-section substitution for setenv setting.

→ <>

@pytoxbot

This comment has been minimized.

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

"nobody is using that feature" is for some odd reason what i thought. sorry about that. will see to fix things and release a tox-2.3.1 early next week. please stick with tox-2.2 series for the time being.

@pytoxbot pytoxbot closed this Sep 17, 2016

@pytoxbot

This comment has been minimized.

pytoxbot commented Sep 17, 2016

Original comment by @The-Compiler

I've talked with @hpk42 about this already, and this is due to the recent changes breaking getting setenv from other environments, like you do with {[tempestenv]setenv}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment