Tox 2.3 regression

[pytoxbot]

• Bitbucket: https://bitbucket.org/hpk42/tox/issue/294
• Originally reported by: jordan_pittier
• Originally created at: 2015-12-11T17:16:51.382

Hi,
At least two openstack project (Tempest and Nova) are hit by a regression introduced with Tox 2.3 released a couple of hours ago on pypi.

Here is a relevant stack trace:

#!shell

(toxtox)jordan@jordan-XPS13:/opt/stack/tempest (master %=)$ tox --version
2.3.0 imported from /opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/__init__.pyc
(toxtox)jordan@jordan-XPS13:/opt/stack/tempest (master %=)$ tox -epep8
Traceback (most recent call last):
  File "/opt/stack/tempest/toxtox/bin/tox", line 11, in <module>
    sys.exit(cmdline())
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/session.py", line 38, in main
    config = prepare(args)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/session.py", line 26, in prepare
    config = parseconfig(args)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 229, in parseconfig
    parseini(config, inipath)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 729, in __init__
    self.make_envconfig(name, section, reader._subs, config)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 760, in make_envconfig
    res = meth(env_attr.name, env_attr.default)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 893, in getdict_setenv
    definitions = self._getdict(value, default=default, sep=sep)
  File "/opt/stack/tempest/toxtox/local/lib/python2.7/site-packages/tox/config.py", line 904, in _getdict
    name, rest = line.split('=', 1)
ValueError: need more than 1 value to unpack

I think Tox failed on these lines:

#!shell

[testenv:all-plugin]
sitepackages = True
# 'all' includes slow tests
setenv = {[tempestenv]setenv}
         OS_TEST_TIMEOUT=1200
deps = {[tempestenv]deps}

Full tox.ini here: https://github.com/openstack/tempest/blob/02ef4c2956318b09cc47506af2361ab3d8907a10/tox.ini

[pytoxbot]

Original comment by jordan_pittier

Quick tests of tox-2.3.1 looks good. I think it's fixed for OpenStack.

[pytoxbot]

Original comment by @hpk42

let me know if tox-2.3.1 is stable again.

[pytoxbot]

Original comment by @hpk42

fix issue294: re-allow cross-section substitution for setenv setting.

→ <>

[pytoxbot]

Original comment by bossylobster

It broke us too: https://github.com/GoogleCloudPlatform/gcloud-python/blob/d6820b91788adcb11aee119349b1489123c12e9f/tox.ini#L56-L58

[pytoxbot]

Original comment by @hpk42

"nobody is using that feature" is for some odd reason what i thought. sorry about that. will see to fix things and release a tox-2.3.1 early next week. please stick with tox-2.2 series for the time being.

[pytoxbot]

Original comment by @The-Compiler

I've talked with @hpk42 about this already, and this is due to the recent changes breaking getting setenv from other environments, like you do with {[tempestenv]setenv}.