Removed unneeded line #3241
Merged
Removed unneeded line #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess it's a copy/paste left-over from `meta_dir`.
The tests complained about the missing changelog, so I added it. I hope I got it right as I was a bit confused about the towncrier dir being empty apart from a template file.
gaborbernat
approved these changes
Mar 8, 2024
welpaolo
pushed a commit
to canonical/spark-k8s-toolkit-py
that referenced
this pull request
Apr 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mypy](https://www.mypy-lang.org/) ([source](https://togithub.com/python/mypy), [changelog](https://mypy-lang.blogspot.com/)) | `1.8.0` -> `1.9.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pytest-mock](https://togithub.com/pytest-dev/pytest-mock) ([changelog](https://pytest-mock.readthedocs.io/en/latest/changelog.html)) | `3.12.0` -> `3.14.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | `4.13.0` -> `4.14.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>python/mypy (mypy)</summary> ### [`v1.9.0`](https://togithub.com/python/mypy/compare/v1.8.0...1.9.0) [Compare Source](https://togithub.com/python/mypy/compare/v1.8.0...1.9.0) </details> <details> <summary>pytest-dev/pytest-mock (pytest-mock)</summary> ### [`v3.14.0`](https://togithub.com/pytest-dev/pytest-mock/blob/HEAD/CHANGELOG.rst#3140-2024-03-21) [Compare Source](https://togithub.com/pytest-dev/pytest-mock/compare/v3.13.0...v3.14.0) - `#​415 <https://github.com/pytest-dev/pytest-mock/pull/415>`\_: `MockType` and `AsyncMockType` can be imported from `pytest_mock` for type annotation purposes. - `#​420 <https://github.com/pytest-dev/pytest-mock/issues/420>`\_: Fixed a regression which would cause `mocker.patch.object` to not being properly cleared between tests. ### [`v3.13.0`](https://togithub.com/pytest-dev/pytest-mock/blob/HEAD/CHANGELOG.rst#3130-2024-03-21) [Compare Source](https://togithub.com/pytest-dev/pytest-mock/compare/v3.12.0...v3.13.0) - `#​417 <https://github.com/pytest-dev/pytest-mock/pull/417>`\_: `spy` now has `spy_return_list`, which is a list containing all the values returned by the spied function. - `pytest-mock` now requires `pytest>=6.2.5`. - `#​410 <https://github.com/pytest-dev/pytest-mock/pull/410>`*: pytest-mock's `setup.py` file is removed. If you relied on this file, e.g. to install pytest using `setup.py install`, please see `Why you shouldn't invoke setup.py directly <https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary>`* for alternatives. </details> <details> <summary>tox-dev/tox (tox)</summary> ### [`v4.14.2`](https://togithub.com/tox-dev/tox/releases/tag/4.14.2) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.14.1...4.14.2) <!-- Release notes generated using configuration in .github/release.yml at 4.14.2 --> #### What's Changed - Removed unneeded line by [@​reinout](https://togithub.com/reinout) in [tox-dev/tox#3241 - Add missing space by [@​droctothorpe](https://togithub.com/droctothorpe) in [tox-dev/tox#3243 - Add Provision Arguments to ToxParser by [@​seyidaniels](https://togithub.com/seyidaniels) in [tox-dev/tox#3246 #### New Contributors - [@​reinout](https://togithub.com/reinout) made their first contribution in [tox-dev/tox#3241 - [@​droctothorpe](https://togithub.com/droctothorpe) made their first contribution in [tox-dev/tox#3243 - [@​seyidaniels](https://togithub.com/seyidaniels) made their first contribution in [tox-dev/tox#3246 **Full Changelog**: tox-dev/tox@4.14.1...4.14.2 ### [`v4.14.1`](https://togithub.com/tox-dev/tox/releases/tag/4.14.1) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.14.0...4.14.1) <!-- Release notes generated using configuration in .github/release.yml at 4.14.1 --> #### What's Changed - Fix fresh subprocesses and allow duplicate register config calls for the core set only by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#3237 **Full Changelog**: tox-dev/tox@4.14.0...4.14.1 ### [`v4.14.0`](https://togithub.com/tox-dev/tox/releases/tag/4.14.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.13.0...4.14.0) <!-- Release notes generated using configuration in .github/release.yml at 4.14.0 --> #### What's Changed - Fix issue/PR number in 4.13.0 changelog by [@​hroncok](https://togithub.com/hroncok) in [tox-dev/tox#3223 - Fix linkcheck failing by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#3229 - Support fresh subprocess for build backends by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#3233 - Allow plugins to attach data to --version by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#3234 **Full Changelog**: tox-dev/tox@4.13.0...4.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 2am on saturday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/spark-k8s-toolkit-py). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it's a copy/paste left-over from
meta_dirwhen creating the documentation for the newfresh_subprocess?(I assume there's no need for a changelog entry for this change? I can add one if desired.)