Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --nodeps command line option #1017

Closed
wants to merge 1 commit into from
Closed

Conversation

janhn
Copy link

@janhn janhn commented Sep 25, 2018

Kindly asking for a review of suggested changes to implement #410.

Tests have been run as suggested in the contributing guide, with and without the change to verify that no failures are being introduced.

=========================== short test summary info ============================
SKIP [1] tests/integration/test_package_int.py:38: flit is Python 3 only
SKIP [1] tests/unit/test_interpreters.py:30: non posix test
XFAIL unit/test_config.py::TestConfigTestEnv::()::test_regression_test_issue_706[envlist0]
  reproduce bug 706
XFAIL unit/test_config.py::TestCmdInvocation::()::test_colon_symbol_in_directory_name
  Upstream bug. See #203

============== 452 passed, 2 skipped, 2 xfailed in 100.44 seconds ==============

@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #1017 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   70.39%   70.38%   -0.02%     
==========================================
  Files          14       14              
  Lines        3486     3491       +5     
  Branches      465      466       +1     
==========================================
+ Hits         2454     2457       +3     
- Misses        971      974       +3     
+ Partials       61       60       -1
Impacted Files Coverage Δ
src/tox/config.py 65.2% <100%> (ø) ⬆️
src/tox/venv.py 79.34% <100%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8d66c...ac68e02. Read the comment docs.

@gaborbernat
Copy link
Member

Hello @janhn, thanks for the contribution. That being said I don't think this is the right direction to go, so I'll close this down now. Can you pick up the discussion and your use case under #410.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants